[REFACTOR] Rename icon methods in IconPainter to reflect what is drawing

[csouchet]

No description provided.

[tbouffard]

❓ why changing this one? I don't get what is the clarification/generalization here. It has already been renamed recently, see https://github.com/process-analytics/bpmn-visualization-js/pull/522/files#diff-5e09027c60c84ce5c53f738dd6ad77bbc15f103d8e0b99de725c8424d7cc2339R307
Be aware that changing this will break the custom icon example

[csouchet]

For me, it represents more a person than a user.
In my opinion, the term 'User' is just to add context to a task.

This icon can be used anywhere (but not sure if we re-use it), but not in the context of 'User'.

Good catch for the examples 😉

[aibcmars]

for general context Person sounds better - so it depends if we want to reuse it elsewhere or just for task-icon

I would even propose to name it paintFemalePersonIcon as it actually draws a female :)

[csouchet]

We changed paintWomanIcon in paintUserIcon in the past, in order to allow to a developper to change woman to man.

In my opinion the icon painter should reflect only what it paints. And the class/method who uses it should add the context.
Maybe, an intermerdiate method is missing in the task-shapes file to call the paintWomanIcon (whatever its name). And the developper should override this missing method and not the woman method if he wants to use a man icon.

[aibcmars]

that makes sense 👍

[csouchet]

So, do I rename it in paintWomanIcon ?

[aibcmars]

I meant ok for eventual intermediate method and overriding

here it is OK to stay with Person, for me, you can merge as it is (just remember about examples mentioned by Thomas)

[csouchet]

Done in process-analytics/bpmn-visualization-examples#74

[aibcmars]

LGTM