[FIX] Don't display elements of a Collapsed Sub-Process #772
Conversation
|
@tbouffard @aibcmars Is it possible for you to generate the snapshot, because if it's generated from MacOs, there is a diffrence of 0.08862368927704534% for windows & 0.1126230944805684% for Unbuntu. |
done with a54c7b6 |
tbouffard
added
the
BPMN rendering
|
@csouchet I have proposed a refactoring to try to clean the Renderer code (2 commits)
|
We are not testing labels here, so no need to have it here. This avoids configuring os specific thresholds.
csouchet
force-pushed
the
741-Don't_display_elements_of_a_Collapsed_Sub-Process
branch
from
0fa93bb to
9fc2d92
Compare
| }), | ||
| ); | ||
| this.insertEdges(bpmnModel.edges); | ||
| this.insertShapes(displayedModel.pools); |
There was a problem hiding this comment.
👍 It's easier to read, but instead of adding a new class, I will have rather modify the BPMNModel, since we already distinguish between Lane / Pool / Flownode in the shapes.
There was a problem hiding this comment.
Why not but this means removing from the model children of the collapsed subprocess.
I don't see any impacts for now for the rendering but I haven't think about future features that could be impacted by such a change.
There was a problem hiding this comment.
Can we do such a refactoring in another PR. With the current changes, everything occur only in the Render file?
Changes directly in the model will have more impacts, so to keep this PR foccused on the fix, this is probably better to limit changes.
| const subprocesses: Shape[] = []; | ||
| const boundaryEvents: Shape[] = []; | ||
| const otherFlowNodes: Shape[] = []; | ||
| bpmnModel.flowNodes.forEach(shape => { |
There was a problem hiding this comment.
👍
ℹ️ If we change BPMNModel, no need this
There was a problem hiding this comment.
So what do we do for this code. Do we revert the last commit to restore the 3 array filters or do we keep it like this?
cc @aibcmars
csouchet
deleted the
741-Don't_display_elements_of_a_Collapsed_Sub-Process
branch
Closes #741
Bug
Fix