[TEST] Add visual tests for label default position #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have some tests for task. Add tests for - event - gateway - sequence flow
tbouffard
added
the
chore
…way_event_label_default_position
csouchet
reviewed
Oct 13, 2020
| <di:waypoint x="380" y="139" /> | ||
| <di:waypoint x="380" y="235" /> | ||
| </bpmndi:BPMNEdge> | ||
| <bpmndi:BPMNEdge id="BPMNEdge_Flow_1" bpmnElement="Flow_1"> |
There was a problem hiding this comment.
A flow with label bounds is missing 😄
There was a problem hiding this comment.
we already have such flows in the labels.01.general.bpmn file
There was a problem hiding this comment.
The value of STYLE_VERTICAL_ALIGN is not the same if there is label bounds.
And the label position changes in all cases if we change the value of STYLE_VERTICAL_ALIGN.
There was a problem hiding this comment.
Are you sure this comment is related to this thread? I don't get it
csouchet
approved these changes
Oct 13, 2020
…way_event_label_default_position # Conflicts: # test/e2e/bpmn.rendering.test.ts
tbouffard
deleted the
test/add-visualization-tests_for_edge_gateway_event_label_default_position
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have some tests for task. Add tests for