[FEAT] Allow to zoom the BPMN diagram with mouse wheel #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
the
depends on another PR ⚠️
tbouffard
changed the title
tbouffard
force-pushed
the
730-zoom_with_mouse_wheel
branch
from
650e3b2 to
aa65a4d
Compare
tbouffard
added
BPMN diagram usability
tbouffard
force-pushed
the
730-zoom_with_mouse_wheel
branch
from
2ee8cb4 to
c41cb8f
Compare
aibcmars
removed
the
rebase needed 💥
Mac OSFirefox
=> Browser Zoom, even the button is zoom/dezoom (cursor position on task) Safari
|
# Conflicts: # test/e2e/bpmn.navigation.test.ts
csouchet
reviewed
Oct 15, 2020
src/component/BpmnVisualization.ts
Outdated
| @@ -31,7 +31,8 @@ export default class BpmnVisualization { | |||
| } | |||
| // Instantiate and configure Graph | |||
| const configurator = new MxGraphConfigurator(this.container); | |||
| this.graph = configurator.configure(options); | |||
| this.graph = configurator.configure(); | |||
| configurator.configureMouseNavigationSupport(options); | |||
There was a problem hiding this comment.
Why don't put this in configurator.configure() ?
There was a problem hiding this comment.
I guess I missed to reintegrate it after refactoring, the configureMouseNavigationSupport method was previously hold in BpmnVisualization
I will put everything within the MxGraphConfigurator.configure
aibcmars
reviewed
Oct 15, 2020
| const deltaX = zoom === 'zoom in' ? -100 : 100; | ||
| // simulate mouse+ctrl zoom | ||
| await page.mouse.move(viewportCenterX, viewportCenterY); | ||
| await page.keyboard.down('Control'); |
There was a problem hiding this comment.
I forgot to check it but it seems it is working well on Mac in our GitHub 'checks' :)
perhaps puppeteer handles that
There was a problem hiding this comment.
puppeteer is running Chromium. Let's review this in #773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zoom support with CTRL + mouse wheel for Linux and Windows.
As discussed with @csouchet, macOS support will be managed with #773.
closes #730