Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Convert expectFont function to jest extension #704

Merged
merged 4 commits into from
Oct 9, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Oct 5, 2020

Covers #673

@csouchet csouchet added depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Oct 5, 2020
@csouchet csouchet force-pushed the refactor/convert_expectFont_to_jest_extension branch from bd91205 to 3b79fc6 Compare October 6, 2020 13:03
@csouchet csouchet changed the title [TEST] Convert expectFont to jest extension [TEST] Convert expectFont function to jest extension Oct 6, 2020
@csouchet csouchet force-pushed the refactor/convert_expectFont_to_jest_extension branch 5 times, most recently from 737daba to 885265a Compare October 8, 2020 13:11
@csouchet csouchet force-pushed the refactor/convert_expectFont_to_jest_extension branch from 885265a to 103e7cc Compare October 9, 2020 09:39
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Oct 9, 2020
@csouchet csouchet marked this pull request as ready for review October 9, 2020 09:40
@csouchet csouchet requested review from aibcmars and tbouffard October 9, 2020 09:40
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
New failure message is great

Expected font of the cell with id 'start_event_none_id' to be equals to:
  {"fontFamily": "Nirvana", "fontSize": 11.5, "fontStyle": 1}
Received:
  {"fontFamily": "Arial", "fontSize": 11, "fontStyle": 1}

Difference:

- Expected
+ Received

  Object {
-   "fontFamily": "Nirvana",
-   "fontSize": 11.5,
+   "fontFamily": "Arial",
+   "fontSize": 11,
    "fontStyle": 1,
  }

@tbouffard tbouffard merged commit d03413d into master Oct 9, 2020
@tbouffard tbouffard deleted the refactor/convert_expectFont_to_jest_extension branch October 9, 2020 10:37
@csouchet csouchet added the hacktoberfest-accepted Accepted Pull Request during Hacktoberfest label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted Pull Request during Hacktoberfest refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants