Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Prepare publish to npmjs #692

Merged
merged 9 commits into from
Oct 5, 2020
Merged

[INFRA] Prepare publish to npmjs #692

Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f6a0b8
Update package.json
csouchet Oct 2, 2020
709bde0
Add .npmignore
csouchet Oct 2, 2020
8597434
Update package.json
tbouffard Oct 5, 2020
368d678
Delete .npmignore
tbouffard Oct 2, 2020
5bbbb11
order package.json fields
tbouffard Oct 5, 2020
d4893bb
Merge branch 'master' into 597-Publish_to_npmjs
csouchet Oct 5, 2020
5222a19
Merge branch 'master' into 597-Publish_to_npmjs
csouchet Oct 5, 2020
6e9ae27
Merge branch 'master' into 597-Publish_to_npmjs
csouchet Oct 5, 2020
4573984
Merge branch 'master' into 597-Publish_to_npmjs
csouchet Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 50 additions & 16 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,48 @@
"name": "bpmn-visualization",
"version": "0.3.1",
"description": "A TypeScript library to visualize process execution data on BPMN diagrams",
"repository": "https://github.com/process-analytics/bpmn-visualization-js",
"keywords": [
"bpmn2",
"bpmn",
"javascript",
"typescript",
"ui-components",
"diagrams",
"visualization",
"process-analytics",
"view",
"bpmn-support",
"analytics",
"diagram",
"viewer"
],
"homepage": "https://github.com/process-analytics/bpmn-visualization-js#readme",
"bugs": "https://github.com/process-analytics/bpmn-visualization-js/issues" ,
"license": "Apache-2.0",
"contributors": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ do we want to maintain this list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the list changes a lot.
If I understand the npm documentation, it's just the top-level maintainers : https://docs.npmjs.com/files/package.json#people-fields-author-contributors

Copy link
Member

@tbouffard tbouffard Oct 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm doc

npm also sets a top-level “maintainers” field with your npm user info.

Ok let's start with this list then 😃

{
"name" : "Thomas Bouffard",
"url" : "https://github.com/tbouffard"
},
{
"name" : "Céline Souchet",
"url" : "https://github.com/csouchet"
},
{
"name" : "Marcin Michniewicz",
"url" : "https://github.com/aibcmars"
}
],
"repository": {
"type": "git",
"url": "git+https://github.com/process-analytics/bpmn-visualization-js.git"
},
"browser": "dist/bpmn-visualization.js",
"module": "dist/bpmn-visualization.esm.js",
"types": "dist/bpmn-visualization.d.ts",
"files": [
"dist"
],
"types": "dist/bpmn-visualization.d.ts",
"scripts": {
"all": "run-s clean lint lint-check build test",
"clean": "rimraf build coverage dist",
Expand All @@ -32,16 +66,10 @@
"test:e2e": "cross-env DEBUG=test JEST_IMAGE_SNAPSHOT_TRACK_OBSOLETE=1 jest --runInBand --detectOpenHandles --config=jest.config.e2e.js",
"test:e2e:coverage": "cross-env JEST_IMAGE_SNAPSHOT_TRACK_OBSOLETE=1 jest --runInBand --detectOpenHandles --config=jest.config.e2e.js --coverage"
},
"lint-staged": {
"*.{js,ts,tsx}": [
"eslint --fix",
"git add"
]
},
"husky": {
"hooks": {
"pre-commit": "tsc --noEmit && lint-staged"
}
"dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for having the dependencies prior tools config

"entities": "^2.0.0",
"fast-xml-parser": "^3.17.4",
"mxgraph": "4.1.0"
},
"devDependencies": {
"@rollup/plugin-json": "^4.1.0",
Expand Down Expand Up @@ -89,9 +117,15 @@
"ts-mxgraph": "git+https://github.com/process-analytics/ts-mxgraph.git#v1.0.1",
"typescript": "^3.9.7"
},
"dependencies": {
"entities": "^2.0.0",
"fast-xml-parser": "^3.17.4",
"mxgraph": "4.1.0"
"lint-staged": {
"*.{js,ts,tsx}": [
"eslint --fix",
"git add"
]
},
"husky": {
"hooks": {
"pre-commit": "tsc --noEmit && lint-staged"
}
}
}