[TEST] Update error message in e2e tests #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
force-pushed
the
672-Update_error_message_in_e2e_tests
branch
from
766171d to
58f70c7
Compare
tbouffard
reviewed
Oct 2, 2020
test/e2e/mxGraph.model.test.ts
Outdated
| const cell = bpmnVisualization.graph.model.getCell(cellId); | ||
| if (cell) { | ||
| return { | ||
| message: () => `Expected cell with id '${cellId}' NOT to be defined`, |
There was a problem hiding this comment.
❓ if this more accurate, I guess that when the expect pass, we have to provide what is ok
Suggested change
| message: () => `Expected cell with id '${cellId}' NOT to be defined`, | |
| message: () => `Expected cell with id '${cellId}' exists in the mxGraph model`, |
There was a problem hiding this comment.
The message must be negative. See the Jest exemple: https://jestjs.io/docs/en/expect#expectextendmatchers
I run the test with a error, and the right message is displayed.
There was a problem hiding this comment.
Fair enough, I hadn't found the Jest expect convention.
The Jest doc is clear about that and the new messages are fine.
tbouffard
reviewed
Oct 2, 2020
test/e2e/mxGraph.model.test.ts
Outdated
| }; | ||
| } else { | ||
| return { | ||
| message: () => `Expected cell with id '${cellId}' to be defined`, |
There was a problem hiding this comment.
Suggested change
| message: () => `Expected cell with id '${cellId}' to be defined`, | |
| message: () => `Expected cell with id '${cellId}' not found in the mxGraph model`, |
There was a problem hiding this comment.
The message must be positive.
tbouffard
reviewed
Oct 2, 2020
The messages are updated. But, the expectations are good as they are. |
Ensure we call the expect 'toBeCell' function for better feedbacks on test failure
csouchet
force-pushed
the
672-Update_error_message_in_e2e_tests
branch
from
ccd7291 to
8220ad6
Compare
csouchet
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom message when a cell is not defined
Closes #672