Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Split contributing guide #632

Merged
merged 7 commits into from
Sep 22, 2020
Merged

[DOC] Split contributing guide #632

merged 7 commits into from
Sep 22, 2020

Conversation

csouchet
Copy link
Member

No description provided.

@csouchet csouchet added the documentation Improvements or additions to documentation label Sep 16, 2020
@csouchet csouchet force-pushed the split_contributing_guide branch 2 times, most recently from bf7a138 to e6f9ffe Compare September 17, 2020 07:27
@csouchet csouchet marked this pull request as ready for review September 17, 2020 08:11
@csouchet csouchet force-pushed the split_contributing_guide branch from 7caccdf to b4f4bed Compare September 17, 2020 08:31
aibcmars
aibcmars approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tbouffard
tbouffard requested changes Sep 17, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the split, it makes things clearer.

I have just noticed that the development README has not been updated for a while. Currently, it contains only a subset of links to pages of the development folder.
So we should decide if we keep it (in that case, let's update it as part of this PR - I push for this solution) or remove it.
In any case, changes are required

@csouchet
Copy link
Member Author

I agree with the split, it makes things clearer.

I have just noticed that the development README has not been updated for a while. Currently, it contains only a subset of links to pages of the development folder.
So we should decide if we keep it (in that case, let's update it as part of this PR - I push for this solution) or remove it.
In any case, changes are required

Done

@csouchet csouchet requested a review from tbouffard September 21, 2020 08:02
@csouchet csouchet force-pushed the split_contributing_guide branch from 87863a2 to d54c573 Compare September 21, 2020 08:45
@csouchet csouchet requested a review from aibcmars September 21, 2020 09:12
@csouchet csouchet force-pushed the split_contributing_guide branch from d54c573 to 2bd1dc6 Compare September 21, 2020 09:27
aibcmars
aibcmars approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet merged commit a1030cd into master Sep 22, 2020
@csouchet csouchet deleted the split_contributing_guide branch September 22, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibcmars aibcmars aibcmars approved these changes

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csouchet @tbouffard @aibcmars