Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Add visual test for text annotation label #627

Merged
merged 3 commits into from
Sep 15, 2020
Merged

[TEST] Add visual test for text annotation label #627

merged 3 commits into from
Sep 15, 2020

Conversation

aibcmars
Copy link
Contributor

covers #541

@aibcmars aibcmars added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 15, 2020
@tbouffard tbouffard changed the title [INFRA] visual test for text annotation label [TEST] Add visual test for text annotation label Sep 15, 2020
@tbouffard tbouffard mentioned this pull request Sep 15, 2020
Closed
8 tasks
tbouffard
tbouffard approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ On my local Ubuntu 18.04, although we changed the threshold, tests have still been able to detect label positions changes for edge and flownodes
Done by artificially substract 1 to the x label bounds on edge and flownodes independently

@tbouffard tbouffard merged commit 31f1b10 into master Sep 15, 2020
@tbouffard tbouffard deleted the 541-visual_test_text_annotation_label branch September 15, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibcmars @tbouffard