Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Add visual test for associations and annotations #624

Merged
merged 6 commits into from
Sep 15, 2020
Merged

[TEST] Add visual test for associations and annotations #624

merged 6 commits into from
Sep 15, 2020

Conversation

aibcmars
Copy link
Contributor

covers #541

@tbouffard
Copy link
Member

@aibcmars can we remove labels from the added diagram (so remove the threshold) and update the 2 existing labels related diagram.
This is to reduce threshold configuration and limit the number of tests that fail when labels rendering change

@aibcmars aibcmars added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 15, 2020
@tbouffard tbouffard changed the title [INFRA] visual test for associations and annotations [TEST] Add visual test for associations and annotations Sep 15, 2020
@tbouffard tbouffard mentioned this pull request Sep 15, 2020
Closed
8 tasks
tbouffard
tbouffard approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbouffard tbouffard merged commit 9f62bab into master Sep 15, 2020
@tbouffard tbouffard deleted the 541-visual_test_annotations_associations branch September 15, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibcmars @tbouffard