Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Provide VSCode tips in the contributing guide #608

Merged
merged 8 commits into from
Sep 16, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Sep 9, 2020

Closes #155

@csouchet csouchet added the documentation Improvements or additions to documentation label Sep 9, 2020
CONTRIBUTING.md Outdated
@@ -174,6 +162,23 @@ We use [asciidoc](https://asciidoctor.org/docs/what-is-asciidoc/) to write the d

An [AsciiDoc IntelliJ Plugin](https://plugins.jetbrains.com/plugin/7391-asciidoc) is a helpful plugin that permits visualizing .adoc files directly in IntelliJ

##### VS Code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ could we move all IDE tips in a dedicated page in the new docs/dev folder?
The contributing guide is very large and it's currently hard to follow how to contribute vs how to develop (this is also related to contribution but this this more details/setup)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@csouchet csouchet force-pushed the 155-provide_VSCode_tips branch 4 times, most recently from 2d81ae8 to bb19123 Compare September 14, 2020 13:12
@csouchet csouchet marked this pull request as ready for review September 14, 2020 13:36
@csouchet csouchet added the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 14, 2020
@csouchet csouchet force-pushed the 155-provide_VSCode_tips branch from b90a22b to 580b6de Compare September 14, 2020 15:27
@csouchet csouchet force-pushed the 155-provide_VSCode_tips branch from 580b6de to df7f800 Compare September 15, 2020 08:14
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 15, 2020
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aibcmars aibcmars merged commit 33f784f into master Sep 16, 2020
@aibcmars aibcmars deleted the 155-provide_VSCode_tips branch September 16, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Provide VSCode tips in the contributing guide
3 participants