Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] add 'subprocess' visual tests #607

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Sep 9, 2020

cover #541

@aibcmars aibcmars added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 9, 2020
@aibcmars
Copy link
Contributor Author

aibcmars commented Sep 9, 2020

subprocess lanes

image

@aibcmars
Copy link
Contributor Author

aibcmars commented Sep 9, 2020

inner subprocess

image

@tbouffard
Copy link
Member

tbouffard commented Sep 14, 2020

@aibcmars for the subprocess with lanes, what do you think of using elements without icons?
This will avoid that changes in user task or timer event break the test.
I would use abstract task instead of human task and would remove the timer event: the test still covers inner subprocess and elements positioning within the lanes of the subprocess.

I can manage the change from my own.

@aibcmars
Copy link
Contributor Author

@aibcmars for the subprocess with lanes, what do you think of elements without icons?
This will avoid that changes in user task or timer event break the test.
I would use abstract task instead of human task and would remove the timer event: the test still covers inner subprocess and elements positioning within the lanes of the subprocess.

I can manage the change from my own.

good idea 👍

@tbouffard tbouffard changed the title [INFRA] visual test - subprocess [INFRA] add 'subprocess' visual tests Sep 14, 2020
user task --> abstract task
remove timer event
signal end event --> non end event
@aibcmars aibcmars merged commit 1f2df04 into master Sep 15, 2020
@aibcmars aibcmars deleted the 541-visual_test_subprocess branch September 15, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants