Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] shorten imports #603

Merged
merged 2 commits into from
Sep 14, 2020
Merged

[REFACTOR] shorten imports #603

merged 2 commits into from
Sep 14, 2020

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Sep 9, 2020 •
edited by tbouffard
Loading

No description provided.

@aibcmars aibcmars added the refactoring Code refactoring label Sep 9, 2020
tbouffard
tbouffard reviewed Sep 9, 2020
View reviewed changes
src/component/mxgraph/shape/activity-shapes.ts Outdated Show resolved Hide resolved
src/component/mxgraph/config/StyleConfigurator.ts Outdated Show resolved Hide resolved
src/component/mxgraph/StyleUtils.ts Outdated Show resolved Hide resolved
src/component/parser/json/converter/ProcessConverter.ts Outdated Show resolved Hide resolved
test/unit/component/mxgraph/config/StyleConfigurator.test.ts Outdated Show resolved Hide resolved
test/unit/component/mxgraph/render/BpmnCanvas.test.ts Outdated Show resolved Hide resolved
test/unit/component/parser/json/JsonTestUtils.ts Outdated Show resolved Hide resolved
@tbouffard
Copy link
Member

❓ according to you @aibcmars what is the advantage of using callback over raw function call (noob question 😄)?

@aibcmars
Copy link
Contributor Author

aibcmars commented Sep 9, 2020

❓ according to you @aibcmars what is the advantage of using callback over raw function call (noob question 😄)?

Here it is only about the signature, if we pass someFunction() as a parameter the actual parameter will be what someFunction returns.
Our documentReady function takes a function as a parameter that is why we should pass 'someFunction' and not someFunction()

@tbouffard
Copy link
Member

@aibcmars I was reviewing again this PR and IMHO which should split it as it covers 3 different topics.
I am unable to find a short focus name for the PR (instead of the generic refactoring) which is a sign that we are doing too much this here.

@aibcmars aibcmars added the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 14, 2020
@aibcmars
Copy link
Contributor Author

@aibcmars I was reviewing again this PR and IMHO which should split it as it covers 3 different topics.
I am unable to find a short focus name for the PR (instead of the generic refactoring) which is a sign that we are doing too much this here.

I have extracted these 2 minor changes and created 2 separate PRs,
therefore this one will treat only imports

@aibcmars aibcmars removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 14, 2020
@tbouffard tbouffard changed the title [INFRA] refactoring [REFACTOR] shorten imports Sep 14, 2020
@aibcmars aibcmars merged commit 0c225ff into master Sep 14, 2020
@aibcmars aibcmars deleted the infra/refactoring branch September 14, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aibcmars @tbouffard @csouchet