Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Render Script task #588

Merged
merged 6 commits into from
Sep 8, 2020
Merged

[FEAT] Render Script task #588

merged 6 commits into from
Sep 8, 2020

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Sep 8, 2020 •
edited
Loading

@csouchet csouchet added enhancement New feature or request WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft BPMN rendering Something about the way the lib is rendering BPMN elements labels Sep 8, 2020
@csouchet csouchet force-pushed the 583-Render_Script_task branch from 9ce89b6 to cacaaa8 Compare September 8, 2020 09:22
@csouchet
Copy link
Member Author

csouchet commented Sep 8, 2020 •
edited
Loading

The first with 3 lines

image
image

@csouchet
Copy link
Member Author

csouchet commented Sep 8, 2020

The first with 2 lines

image
image

@csouchet csouchet force-pushed the 583-Render_Script_task branch from a6c9bc2 to 9c724fa Compare September 8, 2020 12:22
@csouchet csouchet removed the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Sep 8, 2020
@csouchet csouchet requested review from aibcmars and tbouffard and removed request for aibcmars September 8, 2020 12:26
@csouchet csouchet marked this pull request as ready for review September 8, 2020 12:26
@csouchet csouchet requested a review from aibcmars September 8, 2020 12:26
@csouchet
Copy link
Member Author

csouchet commented Sep 8, 2020 •
edited
Loading

We decided to keep it.

The first with 2 lines

image
image

tbouffard
tbouffard approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thx for the various icon attempts, this really helped for the final choice!

@tbouffard tbouffard merged commit 6e19835 into master Sep 8, 2020
@tbouffard tbouffard deleted the 583-Render_Script_task branch September 8, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Render Script task
2 participants
@csouchet @tbouffard