Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] build docs with npm #568

Merged
merged 1 commit into from
Sep 2, 2020
Merged

[INFRA] build docs with npm #568

merged 1 commit into from
Sep 2, 2020

Conversation

tbouffard
Copy link
Member

This removes the need of having a Docker environment to build the docs.

closes #176

@tbouffard
[INFRA] build docs with npm
3ed7aa8 
This removes the need of having a Docker environment to build the docs.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 2, 2020
csouchet
csouchet approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with node 14.5.0

aibcmars
aibcmars approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbouffard tbouffard merged commit 1393548 into master Sep 2, 2020
@tbouffard tbouffard deleted the 176-build_docs_with_npm branch September 2, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibcmars aibcmars aibcmars approved these changes

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INFRA] build html doc without Docker
3 participants
@tbouffard @csouchet @aibcmars