[FEAT] Render Lane (with SubLanes) #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibcmars
added
the
BPMN rendering
tbouffard
requested changes
Aug 31, 2020
| @@ -179,6 +179,10 @@ export default class StyleConfigurator { | |||
| style[mxConstants.STYLE_HORIZONTAL] = false; | |||
| style[mxConstants.STYLE_SWIMLANE_LINE] = 0; // hide the line between the title region and the content area | |||
|
|
|||
| // TODO manage lane text area rendering. there is no Label neither the size available (we have only attribute name="Text of the Label") | |||
| // perhaps it can be calculated as a difference of starting point (either x or y) between pool, lane, sub-lane ? | |||
| style[mxConstants.STYLE_STARTSIZE] = 30; | |||
There was a problem hiding this comment.
❓ did you try to decrease this value
30 is used for Pool because this seems to be the value a lot of modelers use.
Here we can do whatever we want for regular lanes
30 may be needed for lanes that have sub-lanes as in that case, the lane container seems to behave as the pool
There was a problem hiding this comment.
with 30 it is centered vertically - tested with miwg-test-suite Reference files and BPMN editor
constant added, for pool also
csouchet
reviewed
Aug 31, 2020
tbouffard
reviewed
Aug 31, 2020
tbouffard
reviewed
Aug 31, 2020
| @@ -6,6 +6,7 @@ | |||
| <semantic:participant id="participant_1_id" name="Pool 1" processRef="WFP-6-" /> | |||
| <semantic:participant id="participant_2_id" processRef="process_2" /> | |||
| <semantic:participant id="participant_3_id" name="Black Box Process" /> | |||
| <semantic:participant id="participant_4_id" name="Pool containing sublanes" processRef="process_4" /> | |||
There was a problem hiding this comment.
tbouffard
approved these changes
Sep 1, 2020
csouchet
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #255