[FIX] don't create extra svg block in the demo page #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an extra `BpmnVisualization` instance creation at startup that was responsible of creating the extra svg block.
tbouffard
added
bug
aibcmars
reviewed
Aug 26, 2020
| @@ -19,7 +19,7 @@ import { DropFileUserInterface } from './component/DropFileUserInterface'; | |||
|
|
|||
| export * from './helper'; | |||
|
|
|||
| let bpmnVisualization = new BpmnVisualization(window.document.getElementById('graph')); | |||
| let bpmnVisualization: BpmnVisualization; | |||
There was a problem hiding this comment.
if we do it this way, we must assure that the 'bpmnVisualization' is initialized in the exported function 'handleFileSelect'
another way if someone will try use 'handleFileSelect' without initializing bpmnVisualization - there will be an error in
function loadBpmn() {
...
bpmnVisualization.load(bpmn); // bpmnVisualization is undefined
...
}
aibcmars
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an extra
BpmnVisualizationinstance creation at startup that wasresponsible of creating the extra svg block.
closes #552