[TEST] improve 'events' visual tests #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
chore
8 tasks
Use a BPMN diagram that contains the whole events of the BPMN palette. So, we now test all elements that the lib is currently supported, and we are prepared to test remaining events to support in the future. As the BPMN diagram is too large for the load method using the url query param in the 'visual testing' page, add a new loading method: - allow the test page to load a BPMN diagram using a query param providing the url to the file to load (via the Fetch API) - copy the file from the test fixtures folder to a folder that is served by the test server - pass the relative path to the newly copied file as url parameter to make the page load this file - update the 'visual testing' page to display the BPMN file fetching errors In addition, refactor and share functions used to load the BPMN content in e2e tests.
tbouffard
force-pushed
the
541-improve_events_visu_testing
branch
from
5e5903a to
5145db6
Compare
tbouffard
removed
the
WIP 🚧
tbouffard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covers #541
Use a BPMN diagram that contains the whole events of the BPMN palette. So, we
now test all elements that the lib is currently supported, and we are prepared
to test remaining events to support in the future.
As the BPMN diagram is too large for the load method using the url query param
in the 'visual testing' page, add a new loading method:
- allow the test page to load a BPMN diagram using a query param providing the
url to the file to load (via the Fetch API)
- copy the file from the test fixtures folder to a folder that is served by
the test server
- pass the relative path to the newly copied file as url parameter to make the
page load this file
- update the 'visual testing' page to display the BPMN file fetching errors
In addition, refactor and share functions used to load the BPMN content in e2e
tests.
Note: the test code needs refactorings, I will manage this in a dedicated PR to avoid adding too much changes here