Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Center Activity Markers #538

Merged
merged 6 commits into from
Aug 19, 2020
Merged

[FEAT] Center Activity Markers #538

merged 6 commits into from
Aug 19, 2020

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Aug 18, 2020 •
edited by tbouffard
Loading

closes #466

@aibcmars aibcmars requested a review from tbouffard August 18, 2020 14:48
@aibcmars aibcmars added the enhancement New feature or request label Aug 18, 2020
@tbouffard tbouffard changed the title [FEAT] Render Task Markers improved - to have them centered [FEAT] Center Activity Markers Aug 18, 2020
tbouffard
tbouffard reviewed Aug 18, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we 1st merge #537
This PR is introducing rendering changes, so the tests would detect them.

src/component/mxgraph/shape/render/IconPainter.ts Outdated Show resolved Hide resolved
src/component/mxgraph/shape/activity-shapes.ts Outdated Show resolved Hide resolved
@tbouffard tbouffard added the BPMN rendering Something about the way the lib is rendering BPMN elements label Aug 18, 2020
tbouffard
tbouffard reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation in snapshot a8c8584 shows that

  • visual non-regression test suite has detected a change 👍
  • All the markers that are present are grouped and the whole group centered to the bottom of the shape

@tbouffard
Copy link
Member

tbouffard commented Aug 19, 2020 •
edited
Loading

❓ @aibcmars can you rebase the PR onto the master HEAD please?
I currently see a lot of things that appear as changes whereas they are already in the master branch (mainly visualization non-regression tests) and this makes the review hard to do.

@aibcmars aibcmars force-pushed the 466-activity_marker_position branch from 35fdad1 to a8c8584 Compare August 19, 2020 10:23
@aibcmars
Copy link
Contributor Author

❓ @aibcmars can you rebase the PR onto the master HEAD please?
I currently see a lot of things that appear as changes whereas they are already in the master branch (mainly visualization non-regression tests) and this makes the review hard to do.

indeed, my master on local was not updated
it's all good now

@tbouffard tbouffard merged commit a4fa653 into master Aug 19, 2020
@tbouffard tbouffard deleted the 466-activity_marker_position branch August 19, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Manage activity markers position
2 participants
@aibcmars @tbouffard