Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Organize elements in model_complete_semantic.bpmn #525

Merged

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Aug 13, 2020

It now looks like (bpmn-js screenshot):

image

@csouchet csouchet added the refactoring Code refactoring label Aug 13, 2020
@csouchet csouchet requested a review from tbouffard August 13, 2020 16:00
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Ids and comments are preserved in the source BPMN file, that's great for the file history.

I have noticed some labels which are still superposed, but we can manage this later. This is already a great improvement. ❤️

image

@tbouffard tbouffard changed the title [REFACTOR] Organize elements in model_complete_semantic.bpmn [TEST] Organize elements in model_complete_semantic.bpmn Aug 17, 2020
@tbouffard tbouffard merged commit 88c17b7 into master Aug 17, 2020
@tbouffard tbouffard deleted the refactor/organize_elements_in_model_complete_semantic branch August 17, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants