[FEAT] Render Pool when Participant references a Process #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
enhancement
csouchet
force-pushed
the
254-Render_Pool
branch
from
cdbe66e to
3659b8c
Compare
tbouffard
reviewed
Aug 13, 2020
| } else if (bpmnElement.kind === ShapeBpmnElementKind.POOL) { | ||
| // mxConstants.STYLE_HORIZONTAL is for the label | ||
| // In BPMN, isHorizontal is for the Pool | ||
| styleValues.set(mxConstants.STYLE_HORIZONTAL, bpmnCell.isHorizontal ? '0' : '1'); |
There was a problem hiding this comment.
❓ why not putting a boolean like we do for the lane default style?
style[mxConstants.STYLE_HORIZONTAL] = false;
This is clearer and more understandable. We previously did it when we have a dedicated style entry for the activity isExpanded
But maybe this is a mxGraph constraint?
There was a problem hiding this comment.
I tried to do this, but it's not working.
As we need to convert boolean as string, the final style will be "horizontal=false". But MxGraph wants "horizontal=0".
There was a problem hiding this comment.
ok, fair enough, let keep this as it is
tbouffard
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #254
covers #127
B.2.0
A.4.1