Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Render Non-instantiating Receive task #512

Merged
merged 7 commits into from
Aug 12, 2020
Merged

[FEAT] Render Non-instantiating Receive task #512

merged 7 commits into from
Aug 12, 2020

Conversation

csouchet
Copy link
Member

Closes #272

Expected

image

Result

image

@csouchet csouchet added enhancement New feature or request BPMN rendering Something about the way the lib is rendering BPMN elements labels Aug 12, 2020
@csouchet csouchet force-pushed the 272-Render_Non-instantiating_Receive_task branch from 7f0aedf to 5219db3 Compare August 12, 2020 10:31
@csouchet csouchet marked this pull request as ready for review August 12, 2020 10:47
@csouchet csouchet requested a review from tbouffard August 12, 2020 10:47
tbouffard
tbouffard approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/component/mxgraph/shape/activity-shapes.ts Show resolved Hide resolved
@csouchet csouchet merged commit db3e27c into master Aug 12, 2020
@csouchet csouchet deleted the 272-Render_Non-instantiating_Receive_task branch August 12, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Render Non-instantiating Receive task
2 participants
@csouchet @tbouffard