[REFACTOR] Call position methods in PaintParameter #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition_in_icon_parameter
7 tasks
tbouffard
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
LGTM, I like it 👍
Before the implementation, I had the feeling that passing functions will be a mess, but here, this is pretty clear. Thanks
✔️ I have checked that the icon origin are set as before by carefully checking the code and visually with B.1.0 and B.2.0.
tbouffard
changed the title
…ition_in_icon_parameter
csouchet
deleted the
refactor/pass_method_to_calculate_icon_position_in_icon_parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover #247