[FIX] demo code does not interfere with lib integration #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
bug
tbouffard
force-pushed
the
473_demo_code_does_not_interfer_on_lib_integration
branch
3 times, most recently
from
fa27a8d to
c408cea
Compare
tbouffard
changed the title
tbouffard
changed the title
tbouffard
force-pushed
the
473_demo_code_does_not_interfer_on_lib_integration
branch
3 times, most recently
from
d59b336 to
e6f8990
Compare
3 tasks
wip: introduce global exports
wip - 1st implem: demo code hidden in ES6 module
demo code work (no alias)
wip: add page to demonstrate that demo has no side effect on lib integration
wip: add page to demonstrate that demo has no side effect on lib integration
WIP add e2e test diagram for the lib-integration
WIP add e2e test for the lib-integration
make lib-integration.html page display the graph
ensure IconPainter is exported
fix e2e test: lib integration page
ensure default from internal modules are exported in the bundle
reactivate terser compress and mangle
thanks to the new es6 exports defined in the index.ts, terser is able to
generate a minified bundle including right export names.
The minified bundle size decreases from 180.99 kb to 129.64 kb.
export{or as BpmnVisualization,lr as DropFileUserInterface,I as IconPainter,O as
IconPainterProvider,i as MarkerIdentifier,N as StyleConfigurator,s as
StyleDefault,a as StyleIdentifier,x as buildPaintParameter,y as
computeScaledIconSize,ir as documentReady,dr as handleFileSelect,ur as loadBpmn,
sr as log,ar as logStartup,pr as readAndLoadFile};
Clarify the code: what is important is now first
Allow to configure the id of the html element used as visualization container. In the 'non regression' page, no need to define used div and use a custom id for the viewport that will make the graph fit the page. # Conflicts: # src/demo/index.ts
It is loaded indirectly by the js app code that requires it (via import)
tbouffard
force-pushed
the
473_demo_code_does_not_interfer_on_lib_integration
branch
from
a5c8dac to
6df5f79
Compare
tbouffard
removed
the
WIP 🚧
|
Notice that there are TODO about imports/exports. |
aibcmars
approved these changes
Aug 20, 2020
tbouffard
deleted the
473_demo_code_does_not_interfer_on_lib_integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #473
The demo code is now hidden in a module and don't have side effects (globals, require html elements available in the page). The demo bootstrap code specific to the demo page is defined in a dedicated JavaScript script.
To be able to access to the demo and lib code in the demo JS code, we now a 1st set of elements (functions, classes, ....) exported by the lib.
To ensure that there is no more lib integration issue, we have added a dedicated page using specific code that are not using the demo code at all (only the lib code). A new specific e2e view test ensures that this page is working.
The terser compress and mangle configuration has been reactivated: thanks to the new
exports defined in the index.ts, terser is able to generate a minified bundle including
right export names.
The minified bundle size then decreases from
189.64 kb(master 3bf93fb) to135.85 kb(6df5f79).We also added some refactoring
Notes