[FEAT] render activity multi instance markers #471
Conversation
tbouffard
added
enhancement
|
Initial rendering with the BPMN Diagram from process-analytics/bpmn-visualization-examples#32
|
|
@tbouffard Is it possible to have more spaces between the lines of the icon, and the lines thinner ? |
| }); | ||
| canvas.setIconOriginToShapeBottomLeft(); | ||
|
|
||
| c.setFillColor(icon.strokeColor); |
There was a problem hiding this comment.
I tought we have a intermediate method just for the icon drawing, and rotate it if it's a sequential or a parallel, like for the gateway cross 🙂
There was a problem hiding this comment.
I initially planned to do this but as the code is simple, I skipped doing it
I will review that once dependent PR are merged and this one is rebased
There was a problem hiding this comment.
hm, this doesn't work very well in this case.
The rotation applies to the latest close path, here we have 3 paths , so only the latest rectangle is rotated.
This work well for the gateway cross because it is a single path
|
New rendering with more space between bars
|
Render both sequential and parallel markers.
previous implementation paint the stroke which enlarged the bar
tbouffard
force-pushed
the
353-354-render_multi-instantiation_activity_markers
branch
from
481b545 to
a24392d
Compare
tbouffard
removed
the
depends on another PR ⚠️
tbouffard
deleted the
353-354-render_multi-instantiation_activity_markers
branch
Render both sequential and parallel markers.
closes #353
closes #354
closes #450
closes #451
closes #454
closes #455