Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] do not minify public API in the bundle #461

Merged
merged 6 commits into from
Aug 10, 2020

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 5, 2020

The default terser options minified everything, including class and function
names which prevent to use the bundle in the examples.

See also process-analytics/bpmn-visualization-examples#29

The default terser options minified everything, including class and function
names which prevent to use the bundle in the examples.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 5, 2020
@tbouffard
Copy link
Member Author

tbouffard commented Aug 5, 2020

This implementation disables the compress and mangle.
The bundle size increases from 128.41 kb to 178.85 kb (the current size may has changed because this info was taken prior rebase of this PR).
We will refine the configuration to try to reduce the size when managing the npm package.

@tbouffard tbouffard changed the title [INFRA] do not minified public API in the bundle [INFRA] do not minify public API in the bundle Aug 5, 2020
@tbouffard tbouffard added the lib integration Something about how an app can integrate the library label Aug 5, 2020
@tbouffard tbouffard marked this pull request as ready for review August 6, 2020 12:58
@tbouffard tbouffard requested a review from csouchet August 6, 2020 12:59
@tbouffard
Copy link
Member Author

✔️ I have tested the https://github.com/process-analytics/bpmn-visualization-examples/ with the demo bundle generated from this PR and examples are working

@tbouffard tbouffard merged commit fb2cc68 into master Aug 10, 2020
@tbouffard tbouffard deleted the infra/do_not_minimy_class_and_function_names branch August 10, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) lib integration Something about how an app can integrate the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants