[INFRA] Activate noImplicitAny compiler option
#460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
the
chore
csouchet
force-pushed
the
421-noImplicitAny
branch
2 times, most recently
from
bd182f1 to
81267fb
Compare
csouchet
added
the
depends on another PR ⚠️
tbouffard
changed the title
noImplicitAny compiler option
csouchet
force-pushed
the
421-noImplicitAny
branch
from
81267fb to
5ab41d1
Compare
csouchet
force-pushed
the
421-noImplicitAny
branch
from
48b755d to
c27f8f2
Compare
csouchet
force-pushed
the
421-noImplicitAny
branch
from
c27f8f2 to
dc06629
Compare
csouchet
removed
the
depends on another PR ⚠️
tbouffard
reviewed
Aug 5, 2020
Comment on lines
117
to
123
| } else if (kind === ShapeBpmnElementKind.TEXT_ANNOTATION) { | ||
| const name = 'text' in bpmnElement ? bpmnElement.text.toString() : undefined; | ||
| shapeBpmnElement = new ShapeBpmnElement(bpmnElement.id, name, kind, processId); | ||
| } else { | ||
| const name = kind === ShapeBpmnElementKind.TEXT_ANNOTATION ? bpmnElement.text : bpmnElement.name; | ||
| shapeBpmnElement = new ShapeBpmnElement(bpmnElement.id, name, kind, processId, bpmnElement.instantiate); | ||
| const name = 'name' in bpmnElement ? bpmnElement.name : undefined; | ||
| const instantiate = 'instantiate' in bpmnElement ? bpmnElement.instantiate : undefined; | ||
| shapeBpmnElement = new ShapeBpmnElement(bpmnElement.id, name, kind, processId, instantiate); |
There was a problem hiding this comment.
❓ I don't fully understand why this change is needed?
There was a problem hiding this comment.
If we don't use any as type, there is an error, because all the types don't have all the properties.
So, we can keep as it was before, or we can have it, or we can separate all flownode convertions in dedicated converters.
There was a problem hiding this comment.
ok I understand now, I have also done some test locally to see what kind of errors the TS compiler generates.
I don't think we gain something on the code readability here, the code is now harder to read now IMHO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers #421
Already activated, but I remove some ignoring comments