Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Unit json test: Replace some tests by test templates #439

Merged
merged 8 commits into from
Jul 23, 2020
Merged

[REFACTOR] Unit json test: Replace some tests by test templates #439

merged 8 commits into from
Jul 23, 2020

Conversation

csouchet
Copy link
Member

No description provided.

@csouchet csouchet added the refactoring Code refactoring label Jul 22, 2020
@csouchet csouchet force-pushed the refactor_unit_json_test_step3 branch from 2199827 to 31f3aa5 Compare July 22, 2020 15:58
@csouchet csouchet force-pushed the refactor_unit_json_test_step3 branch from 31f3aa5 to 187034b Compare July 22, 2020 15:59
@csouchet csouchet force-pushed the refactor_unit_json_test_step3 branch from d574dc7 to 8ccf1ef Compare July 22, 2020 16:05
@csouchet csouchet requested a review from aibcmars July 22, 2020 16:09
@csouchet csouchet marked this pull request as ready for review July 22, 2020 16:09
aibcmars
aibcmars approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet merged commit 7b9cf43 into master Jul 23, 2020
@csouchet csouchet deleted the refactor_unit_json_test_step3 branch July 23, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibcmars aibcmars aibcmars approved these changes

Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @aibcmars