Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Render Interrupting Message Intermediate Event Attached to an Activity Boundary #338

Merged
merged 3 commits into from
Jun 24, 2020
Merged

[FEAT] Render Interrupting Message Intermediate Event Attached to an Activity Boundary #338

merged 3 commits into from
Jun 24, 2020

Conversation

csouchet
Copy link
Member

Closes #331

With B.2.0

image

@csouchet csouchet added enhancement New feature or request BPMN rendering Something about the way the lib is rendering BPMN elements labels Jun 24, 2020
@csouchet csouchet force-pushed the 331-Render_Interrupting_Message_Boundary_Event branch from 072862c to d939400 Compare June 24, 2020 12:58
@csouchet csouchet mentioned this pull request Jun 24, 2020
Merged
@csouchet csouchet marked this pull request as ready for review June 24, 2020 13:03
@tbouffard tbouffard requested review from tbouffard and aibcmars June 24, 2020 15:28
tbouffard
tbouffard approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Model e2e tests already existed and didn't require changes

@tbouffard tbouffard merged commit 64af756 into master Jun 24, 2020
@tbouffard tbouffard deleted the 331-Render_Interrupting_Message_Boundary_Event branch June 24, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Render Interrupting Message Intermediate Event Attached to an Activity Boundary
2 participants
@csouchet @tbouffard