refactor: use internals instead of private class elements #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace pure private methods (i.e. method not using class instance property) by functions to better encapsulate the implementation logic. Do the same for private properties that can be replaced by constants. Such private methods and properties were generated as public in the JavaScript code, which was not necessary.
|
♻️ PR Preview bab9666 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview bab9666 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
csouchet
approved these changes
Mar 4, 2024
tbouffard
deleted the
refactor/const_funct_instead_of_pure_private_methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace pure private methods (i.e. method not using class instance property) by functions to better encapsulate the implementation logic.
Do the same for private properties that can be replaced by constants. Such private methods and properties were generated as public in the JavaScript code, which was not necessary.
Notes
Continue the work started in #3041.