Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(JsonBuilder): avoid duplicated code when adding EventDefinition #2901

Merged
merged 8 commits into from
Oct 2, 2023
Merged

test(JsonBuilder): avoid duplicated code when adding EventDefinition #2901

merged 8 commits into from
Oct 2, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Sep 29, 2023 •
edited
Loading

Avoid duplication to add EventDefinition in the Definitions or in the Event objects:

  • remove addEventDefinitionsOnEvent and addEventDefinitionsOnDefinition. The code was very similar.
  • add addEventDefinitions

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 29, 2023
@csouchet csouchet changed the title test(JsonBuilder): mutualize code to add EventDefinition in the Definitions or in the Event objects test(JsonBuilder): avoid duplication to add EventDefinition in the Definitions or in the Event objects Sep 29, 2023
@csouchet csouchet changed the title test(JsonBuilder): avoid duplication to add EventDefinition in the Definitions or in the Event objects test(JsonBuilder): avoid duplication when adding EventDefinition Sep 29, 2023
@csouchet csouchet force-pushed the test/simplify_how_add_event_definition_with_JsonBuilder branch from 7b34a93 to ac0fdf0 Compare September 29, 2023 16:02
@csouchet csouchet marked this pull request as ready for review September 29, 2023 16:10
@csouchet csouchet requested a review from tbouffard September 29, 2023 16:10
@csouchet csouchet force-pushed the test/simplify_how_add_event_definition_with_JsonBuilder branch from ac0fdf0 to 20e35fa Compare October 2, 2023 12:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet changed the title test(JsonBuilder): avoid duplication when adding EventDefinition test(JsonBuilder): avoid duplicated code when adding EventDefinition Oct 2, 2023
@csouchet csouchet mentioned this pull request Oct 2, 2023
Merged
@csouchet csouchet merged commit af0cf60 into master Oct 2, 2023
@csouchet csouchet deleted the test/simplify_how_add_event_definition_with_JsonBuilder branch October 2, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard