fix(API): prevent a reset/remove when passing an empty string #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies to the "remove all CSS classes" and "reset style" APIs. These two methods are intended to apply to all elements when a nullish parameter is passed. However, they previously applied to the empty string because the condition was checking the "falsy" state instead. New tests have been added to reproduce the problem and validate the fix.
|
♻️ PR Preview ad2dfb5 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview ad2dfb5 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
changed the title
tbouffard
commented
Oct 2, 2023
| @@ -84,7 +84,7 @@ export class StyleUpdater { | |||
|
|
|||
| resetStyle(bpmnElementIds: string | string[]): void { | |||
| this.graph.batchUpdate(() => { | |||
| if (bpmnElementIds) { | |||
| if (bpmnElementIds || bpmnElementIds == '') { | |||
There was a problem hiding this comment.
thought: we may introduce a function to manage this check
It could improve readability while eliminating duplication (which is not really mandatory here).
csouchet
approved these changes
Oct 2, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix applies to the "remove all CSS classes" and "reset style" APIs.
These two methods are intended to apply to all elements when a "nullish" parameter is passed. However, they previously applied to the empty string because the condition was checking the "falsy" state instead.
New tests have been added to reproduce the problem and validate the fix.