Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify how contributions are accepted #2884

Merged
merged 3 commits into from
Sep 21, 2023
Merged

docs: clarify how contributions are accepted #2884

merged 3 commits into from
Sep 21, 2023

Conversation

tbouffard
Copy link
Member

These changes clarify which issues accept contributions and how contributors should interact with core developers.

Closes #2810

Notes

  • wording reviewed with Deepl
  • the proposition described in the issue is not fully implemented as it could lead to the creation of PRs on undesirable subjects, which would then have to be closed. It has been replaced by something clearer (always talk to us, even if an issue is not marked as "PR approved" for now)

that for other PRs, our responsiveness will be significantly reduced based on complexity and priority.

@tbouffard
docs: clarify how contributions are accepted
d1478ff 
These changes clarify which issues accept contributions and how contributors should interact with core developers.
@tbouffard tbouffard added the documentation Improvements or additions to documentation label Sep 21, 2023
@tbouffard tbouffard requested a review from csouchet September 21, 2023 16:00
csouchet
csouchet reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo to fix 🙂

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@tbouffard
Copy link
Member Author

@csouchet all your suggestions have been integrated.

@tbouffard tbouffard requested a review from csouchet September 21, 2023 16:16
@tbouffard tbouffard merged commit eff349c into master Sep 21, 2023
@tbouffard tbouffard deleted the docs/clarify_how_we_accept_external_contributions branch September 21, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Update the Contributing Guide to specify where we want contribution in priority
2 participants
@tbouffard @csouchet