-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): add unicorn/numeric-separators-style
and unicorn/no-zero-fractions
rules
#2880
chore(eslint): add unicorn/numeric-separators-style
and unicorn/no-zero-fractions
rules
#2880
Conversation
🎊 PR Preview 878408f has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2880.surge.sh 🕐 Build time: 0.016s 🤖 By surge-preview |
🎊 PR Preview 79846a1 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2880.surge.sh 🕐 Build time: 0.02s 🤖 By surge-preview |
a98486c
to
878408f
Compare
unicorn/numeric-separators-style
ruleunicorn/numeric-separators-style
and unicorn/no-zero-fractions
rules
878408f
to
f4ef0aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Much more readable
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
To avoid to have to many changes by enabling plugin:unicorn/recommended, I choose to enable some rule one-by-one.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/numeric-separators-style.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-zero-fractions.md
Part of #2824
Covers #2742