Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): add unicorn/numeric-separators-style and unicorn/no-zero-fractions rules #2880

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Sep 20, 2023

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

🎊 PR Preview 878408f has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2880.surge.sh

🕐 Build time: 0.016s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

🎊 PR Preview 79846a1 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2880.surge.sh

🕐 Build time: 0.02s

🤖 By surge-preview

@csouchet csouchet force-pushed the 2742-add_unicorn/numeric-separators-style_rule branch from a98486c to 878408f Compare September 20, 2023 14:19
@csouchet csouchet changed the title chore(eslint): add unicorn/numeric-separators-style rule chore(eslint): add unicorn/numeric-separators-style and unicorn/no-zero-fractions rules Sep 20, 2023
@csouchet csouchet force-pushed the 2742-add_unicorn/numeric-separators-style_rule branch from 878408f to f4ef0aa Compare September 25, 2023 12:48
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 25, 2023
@csouchet csouchet marked this pull request as ready for review September 25, 2023 12:56
@csouchet csouchet requested a review from tbouffard September 25, 2023 12:56
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Much more readable

@csouchet csouchet merged commit d803fe8 into master Sep 25, 2023
@csouchet csouchet deleted the 2742-add_unicorn/numeric-separators-style_rule branch September 25, 2023 13:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants