-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): add unicorn/prefer-logical-operator-over-ternary
rule
#2871
chore(eslint): add unicorn/prefer-logical-operator-over-ternary
rule
#2871
Conversation
🎊 PR Preview a7e979e has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2871.surge.sh 🕐 Build time: 0.02s 🤖 By surge-preview |
🎊 PR Preview a7e979e has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2871.surge.sh 🕐 Build time: 0.014s 🤖 By surge-preview |
prefer-logical-operator-over-ternary
ruleunicorn/prefer-logical-operator-over-ternary
rule
a7e979e
to
74e49bd
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ All checks pass
✔️ Only touch the test code. The library code itself already followed this recommendation. 💪🏿
To avoid to have to many changes by enabling plugin:unicorn/recommended, I choose to enable some rule one-by-one.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-logical-operator-over-ternary.md
Part of #2824
Covers #2742