Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more tests for StyleComputer #2835

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

tbouffard
Copy link
Member

Check the computeStyle methods for

  • font family only
  • pool/lane when isHorizontal not set

Notes

Detected during #2756

Check the `computeStyle` methods for
  - font family only
  - pool/lane when isHorizontal not set
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 29, 2023
@tbouffard tbouffard marked this pull request as ready for review August 29, 2023 08:48
@tbouffard
Copy link
Member Author

ℹ️ The "Code scanning results / API " check timed out for an unknown reason.

@tbouffard tbouffard requested a review from csouchet August 29, 2023 08:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard tbouffard merged commit 2e68fa0 into master Aug 29, 2023
@tbouffard tbouffard deleted the test/add-more-tests-for-StyleComputer branch August 29, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants