refactor: move overlay management out of BpmnElementsRegistry #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BpmnElementsRegistry` has too many responsibilities. It currently manages overlays, style and CSS classes. As a first step to improve the situation, it is possible to start by internally splitting the code into dedicated classes. The changes here begins by extracting the code in charge of the overlays. In addition: - extract the overlays code from GraphCellUpdater to better separate responsibilities - rename converter.ts file for consistency
|
♻️ PR Preview 40c95b8 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 40c95b8 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
approved these changes
Aug 21, 2023
|
Kudos, SonarCloud Quality Gate passed! |
tbouffard
changed the title
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BpmnElementsRegistryhas too many responsibilities. It currently manages overlays, style and CSS classes.To improve the situation, it is possible to start by dividing your code into specific classes.
The changes here extract of the code responsible for overlays. In addition:
GraphCellUpdaterto better separate responsibilities