Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate the code of the demo/test pages to TypeScript #2794

Merged
merged 33 commits into from
Aug 18, 2023

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Aug 17, 2023

We wrote this code in JavaScript because we initially used Rollup to bundle the code of the demo and test pages.
We now use Vite that is able to handle declaration of TS assets in the HTML page.
So switch to TypeScript for better code assist and limit errors.

@tbouffard tbouffard added WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft refactoring Code refactoring labels Aug 17, 2023
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

♻️ PR Preview 78095e4 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

♻️ PR Preview 78095e4 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

dev/ts/shared/controls.ts Outdated Show resolved Hide resolved
dev/ts/pages/index.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tbouffard tbouffard removed the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Aug 17, 2023
@tbouffard tbouffard marked this pull request as ready for review August 17, 2023 16:13
@tbouffard tbouffard requested a review from csouchet August 17, 2023 16:14
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbouffard tbouffard merged commit 2ac896c into master Aug 18, 2023
@tbouffard tbouffard deleted the refactor/demo_migrate_code_to_typescript branch August 18, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants