-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate the code of the demo/test pages to TypeScript #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bd7ab50.
tbouffard
added
WIP 🚧
Pull request in progress and/or not ready for review. Used in addition to marking it as draft
refactoring
Code refactoring
labels
Aug 17, 2023
♻️ PR Preview 78095e4 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
♻️ PR Preview 78095e4 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
tbouffard
commented
Aug 17, 2023
Kudos, SonarCloud Quality Gate passed! |
tbouffard
removed
the
WIP 🚧
Pull request in progress and/or not ready for review. Used in addition to marking it as draft
label
Aug 17, 2023
csouchet
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wrote this code in JavaScript because we initially used Rollup to bundle the code of the demo and test pages.
We now use Vite that is able to handle declaration of TS assets in the HTML page.
So switch to TypeScript for better code assist and limit errors.