Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

process-analytics / bpmn-visualization-js Public

Notifications You must be signed in to change notification settings
Fork 33
Star 237

Code
Issues 82
Pull requests 6
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [POC] Markers rendering improvements #2724

Closed

tbouffard wants to merge 39 commits into master from poc/marker_rendering_improvements

Conversation 9 Commits 39 Checks 5 Files changed

Closed

chore: [POC] Markers rendering improvements #2724

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

START MARKER RENDERING getMarkerIconOriginFunction: use if/else to pr…

tbouffard Mar 4, 2024

Shape: fake implem of the adhoc marker to handle the position for 3 m…

tbouffard May 30, 2023

Shape: 1st implem for positioning 3 markers

tbouffard May 31, 2023

wip marker position generalization

tbouffard May 31, 2023

TMP remove all GH workflows for the POC

tbouffard May 31, 2023

tbouffard Mar 1, 2024

activity-shapes.ts: remove commented code

tbouffard Mar 4, 2024

EXTRA getMarkerIconOriginFunction: improve parameter name

tbouffard Mar 4, 2024

EXTRA fix margin between markers when there is 2 markers

tbouffard Mar 4, 2024

tbouffard Mar 4, 2024

WIP markers position generalization: same for 1 and 3 markers

tbouffard Mar 4, 2024

remove commented code

tbouffard Mar 4, 2024

add todo to manage 4 markers

tbouffard Mar 4, 2024

generalization for 2 and 3 markers

tbouffard Mar 4, 2024

generalization for 2 and 3 markers - simplify the code

tbouffard Mar 4, 2024

generalization for 4 markers

tbouffard Mar 4, 2024

simplify implementation

tbouffard Mar 4, 2024

simplify implementation

tbouffard Mar 4, 2024

WIP icon-painter.ts improve JSDoc (compensation marker)

tbouffard Mar 5, 2024

IconPainter compensation - fix declared icon width (was too large) - …

tbouffard Mar 5, 2024

WIP experiment compensation marker --> need to set the width

tbouffard Mar 5, 2024

WIP experiment compensation marker --> use fixed width

tbouffard Mar 5, 2024

WIP experiment compensation marker --> correctly positioned

tbouffard Mar 5, 2024

newBpmnCanvas: add JSDoc

tbouffard Mar 5, 2024

BpmnCanvas: simplify scaling computation when iconWidth is set

tbouffard Mar 5, 2024

FIX side effects: configure paintLoop to not update the iconConfig sh…

tbouffard Mar 5, 2024

WIP enforce markers width

tbouffard Mar 5, 2024

refactor: use map instead of switch to manage the marker painters (as…

tbouffard Mar 5, 2024

getMarkerIconOriginFunction: simplify algo + add comments to explain …

tbouffard Mar 6, 2024

IconPainter.paintLoopIcon add comment about why changing impl (fix)

tbouffard Mar 6, 2024

EXTRA refactor event icon management as for activity marker (no defau…

tbouffard Mar 6, 2024

markers.01.positioning.bpmn: add more markers for compensation

tbouffard Mar 7, 2024

Allow to center icon marker vertically in icon bounds (when height < …

tbouffard Mar 11, 2024

experiment rendering of the adhoc marker

tbouffard Mar 11, 2024

WIP: enforce markers width to 16 (loop dimensions must be rework)

tbouffard Mar 12, 2024

Rework the loop icon to better center it and use a better width/heigh…

tbouffard Mar 12, 2024

Rename marker icon width and spacing in StyleDefault to clarify intent

tbouffard Mar 18, 2024

Let configure marker icon stroke width + smaller width and spacing

tbouffard Mar 18, 2024

rename values of ShapeBpmnMarkerKind MULTI_INSTANCE_PARALLEL/ MULTI_I…

tbouffard Mar 20, 2024

File filter

Filter by extension

Filter by extension .bpmn (1) .ts (7) .yml (14) All 3 file types selected

Only manifest files

Deleted files Viewed files

Conversations

Failed to load comments.

Loading

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

- - - utils.ts
- - kinds.ts
- markers.01.positioning.bpmn

There are no files selected for viewing

27 changes: 0 additions & 27 deletions 27 .github/workflows/announce-new-release.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

112 changes: 0 additions & 112 deletions 112 .github/workflows/build.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

73 changes: 0 additions & 73 deletions 73 .github/workflows/codeql-analysis.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

19 changes: 0 additions & 19 deletions 19 .github/workflows/dependency-review-pr.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

19 changes: 0 additions & 19 deletions 19 .github/workflows/fill-gh-draft-release.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

39 changes: 0 additions & 39 deletions 39 .github/workflows/generate-demo-preview.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

85 changes: 0 additions & 85 deletions 85 .github/workflows/generate-documentation.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

14 changes: 0 additions & 14 deletions 14 .github/workflows/pr-metadata-checks.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

Loading

Oops, something went wrong.

Loading

Oops, something went wrong.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.