refactor: [POC] Replace mxGraph with maxGraph 0.1.0 #2366

csouchet · 2022-11-23T17:40:17Z

This is a POC and it is not intended to be merged into master, so don't expect to find a high quality code here! 😺

Please don't rebase on master. We don't need it as we just want to evaluate the migration.

Purpose

evaluate the migration effort
detect problems early
provide feedback to the maxGraph community and if possible fixes that we integrated in this PR as workaround
be ready to easily reuse this effort in a new Pull Request to test new maxGraph releases

Gains

apply improvements to the master branch based on feedback collected during this POC
size reduction in bundles: see refactor: [POC] Replace mxGraph with maxGraph 0.1.0 #2366 (comment)

Detected issues in `maxGraph`

Styles

styles not correctly computed. Introduced a workaround that served as base for fix: consider default style when computing effective style properties maxGraph/maxGraph#152
overlays are always place on the bottom right even whereas other values are passed to the constructor. Introduced a workaround to create a fix in maxGraph: fix: CellOverlay constructor use all parameters to set properties maxGraph/maxGraph#159
the start marker and the arrow of the message flows are no more filled in white (by default). fix: correctly manage the markers fill style maxGraph/maxGraph#157
the message flows icon are not positioned at the right place. The child vertex of an edge using relative geometry are not correctly positioned maxGraph/maxGraph#158
improvement: allow to set extra value for style labelPosition to ignore label positioning.
- See refactor: rework label position setting in StyleComputer #2551 for clarification in bpmn-visualization master branch
- fix: update type of the labelPosition property to restore "no align" maxGraph/maxGraph#203

Types

"TS2748 Cannot access ambient const enums when the '--isolatedModules' flag is provided". TS2748 Cannot access ambient const enums when the '--isolatedModules' flag is provided maxGraph/maxGraph#205
CellStateStyle:
- types of properties are too strict and force casting when using extensions. fix: improve style configuration extensibility maxGraph/maxGraph#163
- some properties have bad names, are not used, bad types (number instead of boolean). refactor(style)!: rename/remove properties and types maxGraph/maxGraph#165

Others

extra mxToolip element created in the DOM after the element holding the graph: Extra mxToolip elements created in the DOM maxGraph/maxGraph#200

- Replace mxCellState by CellState - Replace mxCellRenderer by CellRenderer - Replace mxCellOverlay by CellOverlay

- Replace mxSvgCanvas2D.format:(value: string) => number by SvgCanvas2D.format:(value: number) => number

This is too early, we will do it if we actually migrate to maxGraph

This reverts commit cfc224a

…the code We only want to see the technical impacts of the migration to maxGraph here

We only want to see the technical impacts of the migration to maxGraph here Comment will be updated while or after doing the actual migration

We only want to see the technical impacts of the migration to maxGraph here Comment will be updated while or after doing the actual migration This reverts commit 7b1d761

We only want to see the technical impacts of the migration to maxGraph here Comment will be updated while or after doing the actual migration

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

src/component/mxgraph/shape/edges.ts

tbouffard · 2023-07-04T05:02:30Z

POC completed, a new one has just started in #2756.
So closing this PR.

csouchet added 15 commits November 23, 2022 10:40

Uninstall mxgraph

b348567

Install @maxgraph/core

e408d8b

Remove @typed-mxgraph/typed-mxgraph

8a27379

Remove initializer file

cf23662

Update comment

cfc224a

Replace graph.mxClient by Client

a973656

Replace mxMouseEvent by InternalMouseEvent

aed47ef

Replace mxgraph.mxEvent by eventUtils

e22eb7a

- Replace mxCell by Cell

78dce88

- Replace mxCellState by CellState - Replace mxCellRenderer by CellRenderer - Replace mxCellOverlay by CellOverlay

Replace mxPoint by Point

2fe67e2

Replace mxShape by Shape

c3d25d8

Replace mxAbstractCanvas2D by AbstractCanvas2D

0d087c6

Replace mxRectangleShape by RectangleShape

817c114

Replace mxRectangle by Rectangle

540adbd

Replace mxImageShape by ImageShape

9670fb3

csouchet added WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft poc 💫 Experimentation to discuss about future implementation. Not intended to be merged labels Nov 23, 2022

csouchet changed the title ~~[POC] Bump maxgraph to 0.1.0~~ [POC] Replace mxgraph with maxgraph 0.1.0 Nov 23, 2022

Replace mxDictionary by Dictionary

80b3c99

csouchet force-pushed the poc/bump_maxgraph_0.1.0 branch from d6dbba5 to 7da1141 Compare November 24, 2022 10:10

csouchet added 10 commits November 24, 2022 11:17

- Replace mxSvgCanvas2D by SvgCanvas2D

da761e8

- Replace mxSvgCanvas2D.format:(value: string) => number by SvgCanvas2D.format:(value: number) => number

Replace mxGraphView by GraphView

9318fe4

Replace mxImageExport by ImageExport

f3720ee

Replace mxEllipse by EllipseShape

3fd2755

Replace mxRhombus by RhombusShape

d345f8a

Replace mxText by TextShape

e497f2a

Replace mxMarker by MarkerShape

432fe97

Replace mxConnector by ConnectorShape

0917c5f

Replace mxUtils by utils

be478dd

Replace mxGraph by Graph

80177d0

This was referenced Feb 26, 2023

refactor: remove StyleUtils #2550

Merged

refactor: rework label position setting in StyleComputer #2551

Merged

tbouffard mentioned this pull request Jun 4, 2023

test: simplify integration tests #2727

Merged

tbouffard added 15 commits June 4, 2023 22:02

docs: revert "remove mxGraph reference in the documentation"

f12e7a6

This is too early, we will do it if we actually migrate to maxGraph

Revert "Update comment" - restore mxGraph in comments

9960731

This reverts commit cfc224a

restore the "BpmnStyleIdentifier" to reduce the number of changes in …

5a27312

…the code We only want to see the technical impacts of the migration to maxGraph here

StyleComputer: remove extra mxGraph to maxGraph change in comments

29bff4a

We only want to see the technical impacts of the migration to maxGraph here Comment will be updated while or after doing the actual migration

Revert "Rename MxGraphCustomOverlay in MaxGraphCustomOverlay"

7490fa9

We only want to see the technical impacts of the migration to maxGraph here Comment will be updated while or after doing the actual migration This reverts commit 7b1d761

test: restore the filename of the mxgraph config

603fdf1

We only want to see the technical impacts of the migration to maxGraph here Comment will be updated while or after doing the actual migration

test: remove ref to maxGraph in a comment

29bb2f0

We only want to see the technical impacts of the migration to maxGraph here Comment will be updated while or after doing the actual migration

Revert variable rename in GraphCellUpdater.ts (mxCell to cell)

ca24bc4

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

Revert comment update in GraphConfigurator.ts (mxCell to cell)

46fde05

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

Revert comment update in ShapeConfigurator.ts (mxShape to Shape)

59e2e49

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

Revert comment update in custom-overlay.ts

901bb51

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

Revert comment update in CoordinatesTranslator.ts

c2e45ca

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

Revert comment update in query-selectors.ts

ed7373e

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

Revert comment update in style-utils.ts

e322f0d

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

Revert comment update in icon-painter.ts

0610b33

We only want to see the technical impacts of the migration to maxGraph here Comment/variables will be updated while or after doing the actual migration

tbouffard reviewed Jun 7, 2023

View reviewed changes

src/component/mxgraph/shape/edges.ts Show resolved Hide resolved

BpmnConnector: todo about future integration in maxGraph

a70e355

This was referenced Jun 13, 2023

[BUG] Failed to execute 'getComputedStyle' when using lit #2738

Closed

refactor: directly use mxGraph value objects #2745

Merged

tbouffard added mxgraph integration Something involving mxGraph (be aware of EOL) and removed WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Jul 4, 2023

tbouffard mentioned this pull request Jul 4, 2023

refactor: [POC] investigate replacement of mxGraph by [email protected] (2nd attempt) #2756

Closed

tbouffard closed this Jul 4, 2023

tbouffard deleted the poc/bump_maxgraph_0.1.0 branch July 4, 2023 05:02

tbouffard mentioned this pull request May 27, 2024

refactor: [POC] Replace mxGraph with maxGraph 0.10.x #3098

Draft

tbouffard mentioned this pull request Jan 8, 2025

[INFRA] Evaluate the Migration from mxGraph to maxGraph #3238

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: [POC] Replace mxGraph with maxGraph 0.1.0 #2366

refactor: [POC] Replace mxGraph with maxGraph 0.1.0 #2366

csouchet commented Nov 23, 2022 •

edited by tbouffard

Loading

tbouffard commented Jul 4, 2023

refactor: [POC] Replace mxGraph with maxGraph 0.1.0 #2366

refactor: [POC] Replace mxGraph with maxGraph 0.1.0 #2366

Conversation

csouchet commented Nov 23, 2022 • edited by tbouffard Loading

Detected issues in maxGraph

tbouffard commented Jul 4, 2023

csouchet commented Nov 23, 2022 •

edited by tbouffard

Loading

Detected issues in `maxGraph`