-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] README indicates the lowest supported TypeScript version #2251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understood in #2246, it is TS 4.5 for 0.26.1. This does not apply for older releases, right? should we explicitly mention something like "starting from 0.26.1..."?
The README is always about the latest version. I am going to do some tests in the example repository to confirm it |
@assynour previous versions could run with older TypeScript version but the types have major issues that we fixed in https://github.com/process-analytics/bpmn-visualization-js/releases/tag/v0.21.5. For all these reasons, I don't want to add more information in the README and I suggest we keep only valid information for the current release. |
Put the information in the README. This is a first step of larger changes that will be implemented later.
Making it explicit in the README is just a minimum.
refs #2246