Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Do not force usage of orthogonal edge segments #1779

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jan 28, 2022

WIP unfiinished

covers #295 (and other related issues)
New attempt to reimplement #351

e2e tests are failing because

  • threshold are not set for bpmn-rendering tests
  • other tests have not been reviewed (in particular snapshots haven't been recreated)

@tbouffard tbouffard added the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Jan 28, 2022
@github-actions
Copy link

github-actions bot commented Jan 28, 2022

🎊 PR Preview f2e518d has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-1779.surge.sh

🕐 Build time: 40.082s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jan 28, 2022

🎊 PR Preview f2e518d has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-1779.surge.sh

🕐 Build time: 40.159s

🤖 By surge-preview

@tbouffard
Copy link
Member Author

tbouffard commented Jan 28, 2022

Current status

The orthogonal segments are dropped, but we see side effects on sequence and message flow arrows. Depending on the zoom level, they are not aligned with the edge segments.
This can be seen directly by checking the e2e screenshots used for non regression visual testing.

For instance, the arrow of the message flow at the top right of the diagram of flows.message.01.icons-snap.png
flows message 01 icons-snap

Same for the arrow of the sequence flow at the right of the diagram of associations.and.annotations.01.general-snap.png
associations and annotations 01 general-snap

We also see issue like the one described in #351 (comment): we know this happens when the terminal waypoints are outside the shape. Same issue as for #715
See #1863 for an implementation that fixes the issue.

@tbouffard tbouffard force-pushed the 295-fix_do_not_always_use_orthogonal_segments_in_seq_and_msg_flows branch from 1b50b22 to f2e518d Compare February 7, 2022 14:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard tbouffard added bug Something isn't working BPMN rendering Something about the way the lib is rendering BPMN elements labels Mar 16, 2022
@tbouffard
Copy link
Member Author

Closing, a new Pull Request will be created with the work started here and improvements available in #1863

@tbouffard tbouffard closed this Mar 16, 2022
@tbouffard tbouffard changed the title [POC] Do not force usage orthogonal edge segments [POC] Do not force usage of orthogonal edge segments Mar 16, 2022
@tbouffard tbouffard deleted the 295-fix_do_not_always_use_orthogonal_segments_in_seq_and_msg_flows branch March 18, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements bug Something isn't working WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant