-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Do not force usage of orthogonal edge segments #1779
[POC] Do not force usage of orthogonal edge segments #1779
Conversation
🎊 PR Preview f2e518d has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-1779.surge.sh 🕐 Build time: 40.082s 🤖 By surge-preview |
🎊 PR Preview f2e518d has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-1779.surge.sh 🕐 Build time: 40.159s 🤖 By surge-preview |
Current statusThe orthogonal segments are dropped, but we see side effects on sequence and message flow arrows. Depending on the zoom level, they are not aligned with the edge segments. For instance, the arrow of the message flow at the top right of the diagram of Same for the arrow of the sequence flow at the right of the diagram of We also see issue like the one described in #351 (comment): we know this happens when the terminal waypoints are outside the shape. Same issue as for #715 |
Remove style configuration
1b50b22
to
f2e518d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closing, a new Pull Request will be created with the work started here and improvements available in #1863 |
WIP unfiinished
covers #295 (and other related issues)
New attempt to reimplement #351
e2e tests are failing because