[REFACTOR] Don't use special prefix in private field name #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BpmnVisualization.bpmnModelRegistry` field was previously prefixed by a `_` as this is sometime done in other projects as a convention to warn about private fields in JS code. Remember that we don't produce private JS fields at TS compilation as this not widely supported by browsers, so such fields are ultimately visible. This was not consistent with the rest of the code base, so the prefix has been removed.
|
♻️ PR Preview c700db8 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview c700db8 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
Kudos, SonarCloud Quality Gate passed! |
Additional informationThis underscored field name has been introduced in #1115, and the non consistent issue was detected after the PR merge: #1115 (review) The private class fields proposal is currently a TC39 stage 3 candidate |
aibcmars
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BpmnVisualization.bpmnModelRegistryfield was previously prefixed by a_as this is sometime done in other projects as a convention to warn about private
fields in JS code. Remember that we don't produce private JS fields at TS
compilation as this not widely supported by browsers, so such fields are
ultimately visible.
This was not consistent with the rest of the code base, so the prefix has been
removed.