[FIX] Don't store 'edge without bpmn element' in the BpmnModel #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is invalid and was not homogeneous with BPMN Shape that are not stored when we don't get the bpmn element. In addition, this can produced errors in client code as the bpmn element is not supposed to be `undefined`. A dedicated test has been added to manage this use case and parsing tests that were relying on this 'hole' have been updated to use valid edge BPMN sources (mainly tests about edge labels).
tbouffard
added
bug
|
This has been detected when implementing #1115 |
|
Kudos, SonarCloud Quality Gate passed! |
csouchet
reviewed
Feb 17, 2021
| this.convertedElements.findMessageFlow(edge.bpmnElement) || | ||
| this.convertedElements.findAssociationFlow(edge.bpmnElement); | ||
|
|
||
| if (!flow) { |
csouchet
approved these changes
Feb 17, 2021
csouchet
deleted the
fix/do_not_store_edge_with_bpmn_element_in_model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is invalid and was not homogeneous with BPMN Shape that are not stored when
we don't get the bpmn element.
In addition, this can produced errors in client code as the bpmn element is not
supposed to be
undefined.A dedicated test has been added to manage this use case and parsing tests
that were relying on this 'hole' have been updated to use valid edge
BPMN sources (mainly tests about edge labels).