[TEST] Add more BPMN rendering visual tests for labels and waypoints #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
the
WIP 🚧
|
The screenshots presented here have been done with without waypointsDemonstrate what we see in #349
waypoints inside shapesThe mxgraph configuration (we use the defaults for this topic) forces the edges terminals to be on the perimeter of the shapes. Because of #295, the paths are always orthogonal.
waypoints outside shapesThe mxgraph configuration (we use the defaults for this topic) forces the edges terminals to be on the perimeter of the shapes. So we have additional points on the shape, and we see small orthogonal paths because of #295.
|
tbouffard
added
the
chore
Add new tests to check BPMN rendering for - label fonts: ensure the font properties of BPMN Label Styles are used in rendering - waypoints: check how the lib behaves when there is no waypoints and when terminal waypoints are defined inside or outside of the source/target shapes Also always copy test diagrams to destination. On Ubuntu, not overriding files takes 6ms, overriding 12ms. The copy is very fast, and not copying the files has side effects: when editing the diagram it is not updated and we don't see the change in tests. This is hard to debug and error prone.
tbouffard
force-pushed
the
chore/add_more_visual_tests_for_bpmn_rendering
branch
from
5703c7e to
217da31
Compare
tbouffard
removed
the
WIP 🚧
tbouffard
changed the title
csouchet
approved these changes
Jan 19, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new tests to check BPMN rendering for
rendering
terminal waypoints are defined inside or outside of the source/target shapes
Also always copy test diagrams to destination.
On Ubuntu, not overriding files takes 6ms, overriding 12ms.
The copy is very fast, and not copying the files has side effects: when editing
the diagram it is not updated and we don't see the change in tests. This is hard
to debug and error prone.
covers #295, #349, #350, #715, #994