Skip to content

Commit

Permalink
Update diagram rendering visual tests
Browse files Browse the repository at this point in the history
  • Loading branch information
csouchet committed Oct 27, 2020
1 parent 0d5c8d1 commit 809b553
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 0 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions test/e2e/diagram.rendering.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,25 @@ describe('no diagram visual regression', () => {
windows: 0.0035,
},
],
[
'vertical',
// minimal threshold to make test pass on Github Workflow
// ubuntu: Expected image to match or be a close match to snapshot but was 0.0019441198722769393% different from snapshot
// macOS: Expected image to match or be a close match to snapshot but was 0.0019441198722769393% different from snapshot
// windows: Expected image to match or be a close match to snapshot but was 0.0019441198722769393% different from snapshot
{
linux: 0.00002,
macos: 0.00002,
windows: 0.00002,
},
],
]),
);

describe.each([
[FitType[FitType.Default], FitType.Default],
[FitType[FitType.HorizontalVertical], FitType.HorizontalVertical],
[FitType[FitType.Horizontal], FitType.Horizontal],
])('load options: %s fit', async (fitTitle: string, fitType: FitType) => {
const bpmnDiagramPreparation = new BpmnDiagramPreparation(new Map<string, BpmnLoadMethod>([]), { name: 'non-regression' }, 'diagram', { fitType });
const pageTester = new PageTester(bpmnDiagramPreparation, 'viewport', 'BPMN Visualization Non Regression');
Expand Down

0 comments on commit 809b553

Please sign in to comment.