Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

chore(deps): use babel-preset-env instead of babel-preset-es2015 #113

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

probil
Copy link
Owner

@probil probil commented Feb 26, 2018

babel-preset-es2015 is deprecated
https://babeljs.io/env/

@probil probil merged commit 1d3d8a1 into master Feb 26, 2018
@probil probil deleted the feature/use-babel-preset-env-instead-of-es2015 branch February 26, 2018 11:25
@ericmdantas
Copy link

Hey, @probil. The latest version (v1.3.2) still has babel-preset-es2015 as a dependency - is this intended?

It was causing my app to break, because I don't have it installed. Thanks!

@probil
Copy link
Owner Author

probil commented Oct 15, 2018

@ericmdantas
Thanks for your feedback. I will publish 1.3.3 soon with newest package.json

@probil
Copy link
Owner Author

probil commented Oct 15, 2018

@ericmdantas
I've just published v1.3.3 with the fix. Please, verify and let me know.
In any case this is dev dependency so it should not cause any issues

@ericmdantas
Copy link

Thanks for the quick reply, @probil. I appreciate it.

The error I was getting was:

Couldn't find preset "es2015" relative to directory ${PATH_TO_V_MASK}

Now I'm getting a different one:

ERROR in ./node_modules/v-mask/dist/v-mask.esm.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
ReferenceError: Unknown plugin "transform-runtime" specified in "${PATH_TO_V_MASK}.babelrc" 
at 0, attempted to resolve relative to "${PATH_TO_V_MASK}"

Maybe you should have babel stuff as dependencies instead of devDependencies? So it's installed as a dep of v-mask.

Thanks once again.

@probil
Copy link
Owner Author

probil commented Oct 23, 2018

@ericmdantas Your issue is probably related to webpack/browserify/etc configuration

As you can see there is nothing else related to es2015
https://cdn.jsdelivr.net/npm/[email protected]/package.json

@ericmdantas
Copy link

Yeah, I guess it's something on my end. Pretty weird error nonetheless.

Thanks for the help, @probil. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants