Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to build current develop branch, wavefront could not be downloaded #227

Closed
AndrewAnnex opened this issue Aug 23, 2022 · 13 comments
Closed
Assignees

Comments

@AndrewAnnex
Copy link
Collaborator

running build.sh on macos big sur causes the following issue:

Paket failed with
-> Could not download Aardvark.Data.Wavefront 5.2.1.
-> Couldn't get package details for package Aardvark.Data.Wavefront 5.2.1 on https://vrvis.myget.org/F/aardvark/api/v3/index.json.
-> Could not retrieve data from 'https://vrvis.myget.org/F/aardvark/FindPackagesById()?semVerLevel=2.0.0&id='Aardvark.Data.Wavefront''
-> RequestFailedException: Request to 'https://vrvis.myget.org/F/aardvark/FindPackagesById()?semVerLevel=2.0.0&id='Aardvark.Data.Wavefront'' failed with: 401 Unauthorized — <string xmlns="http://schemas.microsoft.com/2003/10/Serialization/">Unauthorized</string>
@AndrewAnnex
Copy link
Collaborator Author

the ability to build branches on macos is a critical issue, as it prevents timely testing and feedback of feature branches by external users

@haraldsteinlechner
Copy link
Collaborator

haraldsteinlechner commented Aug 24, 2022

thanks @AndrewAnnex. Indeed it seems a non-public nuget feed was added recently. Also, currently the CI builds are disabled. I enabled them again, see #228 - so continuous mac builds is of course the plan!

@LauraFritz14 could you please consult @luithefirst @hyazinthh and move the wavefront package into a public feed accordingly (if not possible, wavefront support cannot be in pro3d)

EDIT: the problem can now be seen in github CI actions https://github.com/pro3d-space/PRo3D/runs/7990993277?check_suite_focus=true#step:3:507

@hyazinthh
Copy link
Collaborator

Aardvark.Data.Wavefront has been made public some time ago, you need to update to 5.2.4 or 5.2.5.

https://www.nuget.org/packages/Aardvark.Data.Wavefront

@LauraFritz14
Copy link
Collaborator

LauraFritz14 commented Aug 24, 2022 via email

@haraldsteinlechner
Copy link
Collaborator

oh cool, glad all is set. thanks a lot @LauraFritz14

@haraldsteinlechner
Copy link
Collaborator

haraldsteinlechner commented Aug 24, 2022

@LauraFritz14 your fix is in a bug branch or something, is this branch ready now or soon? because i would like to have your fix in develop branch to check the CI action (e.g. for autodeploy)

EDIT: cherry-picking the little fix with the wavefront package could do the job

@LauraFritz14
Copy link
Collaborator

@haraldsteinlechner this branch is ready. I changed the paket.dependencies and paket.lock files to get the correct path to Aardvark.Data.Wavefront

@haraldsteinlechner
Copy link
Collaborator

ok, i'm a bit detached in my off-time currently, but if you think, you can merge to develop, and i will do the rest to make a test deployment

LauraFritz14 added a commit that referenced this issue Aug 24, 2022
@haraldsteinlechner
Copy link
Collaborator

@LauraFritz14 yes it worked, the build is back for windows and osx: https://github.com/pro3d-space/PRo3D/runs/7997008245?check_suite_focus=true

i will trigger a test deployment on the CI and we will see

@haraldsteinlechner
Copy link
Collaborator

haraldsteinlechner commented Aug 24, 2022

andrew, just to let you know, by pulling in this package, we pulled in other packages transitively (classic), which makes problems at runtime. so no need to retry for now :(

EDIT: just found out a minor version jump introduced an illformed dependency to f# 6.0. this on the go, as well as a workaround i just pushed to the autodeploy and develop branch. @LauraFritz14 could you please test the current heads horoughly, would be great to get rid of those annoying troubles..
krauthaufen/Adaptify#30

@AndrewAnnex
Copy link
Collaborator Author

@haraldsteinlechner okay good to see this getting worked on

@haraldsteinlechner
Copy link
Collaborator

haraldsteinlechner commented Sep 8, 2022

so there is a lot to tell here - a lot of code got merged now, also lurking features from before my vacation time ;) it looks good now I think.

  • for deployment we now use electron (which provides signing, installers etc), the latest build released automatically from autorelease branch works fine. this involves splash screen, output log window and the build process. for this we needed to switch to dotnet 6 for the build script support. unfortunately the apps itself are still dotnet 5, but this should be easy and is outlined here: move to dotnet 6 #232
  • for development, everything can be used as-is
  • generally there is no different code paths for Mac or Win in the deployment / development. Yet there is some work todo to build also JR libraries in the CI (build native libs via CI DaKup/PRo3D-Extensions#5)

The release is not official yet, so please @ThomasOrtner @LauraFritz14 @RebeccaNowak please check develop as well as the automatically deployed release found on the release page.

cheers, Harald

@haraldsteinlechner
Copy link
Collaborator

current develop branch as well as the newest release should fix the mentioned problems (https://github.com/pro3d-space/PRo3D/releases/tag/v4.9.5)
Please note that we switched fully to .net 6 which makes .net 5 sdk unnecessary. Anyhow, also the path's changed. Instead of running dotnet bin/Release/net5.0/PRo3D.Viewer.dll use dotnet bin/Release/net6.0/PRo3D.Viewer.dll". When using dotnet run --project...` nothing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants