-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to build current develop branch, wavefront could not be downloaded #227
Comments
the ability to build branches on macos is a critical issue, as it prevents timely testing and feedback of feature branches by external users |
thanks @AndrewAnnex. Indeed it seems a non-public nuget feed was added recently. Also, currently the CI builds are disabled. I enabled them again, see #228 - so continuous mac builds is of course the plan! @LauraFritz14 could you please consult @luithefirst @hyazinthh and move the wavefront package into a public feed accordingly (if not possible, wavefront support cannot be in pro3d) EDIT: the problem can now be seen in github CI actions https://github.com/pro3d-space/PRo3D/runs/7990993277?check_suite_focus=true#step:3:507 |
Aardvark.Data.Wavefront has been made public some time ago, you need to update to 5.2.4 or 5.2.5. |
I'm sorry, thats my fault. I forgot to change this!
…On 24.08.2022 11:04, Martin wrote:
Aardvark.Data.Wavefront has been made public some time ago, you need
to update to 5.2.4 or 5.2.5.
https://www.nuget.org/packages/Aardvark.Data.Wavefront
—
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF6B4QXXXT46UXCXE5BYTKDV2XQQNANCNFSM57MSPO2A>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
oh cool, glad all is set. thanks a lot @LauraFritz14 |
@LauraFritz14 your fix is in a bug branch or something, is this branch ready now or soon? because i would like to have your fix in develop branch to check the CI action (e.g. for autodeploy) EDIT: cherry-picking the little fix with the wavefront package could do the job |
@haraldsteinlechner this branch is ready. I changed the paket.dependencies and paket.lock files to get the correct path to Aardvark.Data.Wavefront |
ok, i'm a bit detached in my off-time currently, but if you think, you can merge to develop, and i will do the rest to make a test deployment |
@LauraFritz14 yes it worked, the build is back for windows and osx: https://github.com/pro3d-space/PRo3D/runs/7997008245?check_suite_focus=true i will trigger a test deployment on the CI and we will see |
andrew, just to let you know, by pulling in this package, we pulled in other packages transitively (classic), which makes problems at runtime. so no need to retry for now :( EDIT: just found out a minor version jump introduced an illformed dependency to f# 6.0. this on the go, as well as a workaround i just pushed to the autodeploy and develop branch. @LauraFritz14 could you please test the current heads horoughly, would be great to get rid of those annoying troubles.. |
@haraldsteinlechner okay good to see this getting worked on |
…, in order to workaround #227
so there is a lot to tell here - a lot of code got merged now, also lurking features from before my vacation time ;) it looks good now I think.
The release is not official yet, so please @ThomasOrtner @LauraFritz14 @RebeccaNowak please check develop as well as the automatically deployed release found on the release page. cheers, Harald |
current develop branch as well as the newest release should fix the mentioned problems (https://github.com/pro3d-space/PRo3D/releases/tag/v4.9.5) |
running build.sh on macos big sur causes the following issue:
The text was updated successfully, but these errors were encountered: