Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests workflow, including matrix of Python versions #6

Closed
prjemian opened this issue Oct 12, 2024 · 2 comments · Fixed by #8
Closed

Add unit tests workflow, including matrix of Python versions #6

prjemian opened this issue Oct 12, 2024 · 2 comments · Fixed by #8
Assignees

Comments

@prjemian
Copy link
Owner

I'm not happy adding pins that do something already accomplished by package management software. We must not start that. Clearly conda can resolve the package requirements and it is not necessary to pin to a fixed version.

State your technical reasons.

Pinning makes sure that when the package is deployed, it is done so with the exact set of dependencies the team tested with. Bugs will still happen, but it’s much more reliable and consistent than using loose versioning, where the dependencies can vary and cause unexpected issues. As was shown above in Pyarrow not being able to be resolved.

Originally posted by @MDecarabas in #5 (comment)

@prjemian prjemian self-assigned this Oct 12, 2024
prjemian added a commit that referenced this issue Oct 14, 2024
prjemian added a commit that referenced this issue Oct 14, 2024
@prjemian
Copy link
Owner Author

Widened the test matrix to all supported versions of Python that are also known to be supported by bluesky packages. (BS is not ready for Py3.13 yet.)

@prjemian
Copy link
Owner Author

Not testing yet with the queueserver. That can be an upgrade feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant