Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue2125 #2126

Merged
merged 2 commits into from
Sep 9, 2023
Merged

fix: resolve issue2125 #2126

merged 2 commits into from
Sep 9, 2023

Conversation

Monilprajapati
Copy link
Contributor

Related Issue : Issue2125

Filter clear button Issue

Description

Fiter clear button was visible whether there is any filter selected or not.

Screenshots

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Sep 9, 2023 5:38am

@github-actions github-actions bot added the wait for reviewers wait for the maintainer label Sep 8, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Monilprajapati! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@priyankarpal
Copy link
Owner

priyankarpal commented Sep 8, 2023

@Monilprajapati will check soon. Is it your other account? https://github.com/maxpratz

@Monilprajapati
Copy link
Contributor Author

@Monilprajapati will check soon. Is it your other account? https://github.com/maxpratz

Yeahhh I created for an event purpose which i am going to conduct in the next week in my college. Is there any problem?

@Monilprajapati
Copy link
Contributor Author

Monilprajapati commented Sep 8, 2023

@Monilprajapati will check soon. Is it your other account? https://github.com/maxpratz

Yeahhh I created for an event purpose which i am going to conduct in the next week in my college. Is there any problem?

Ohhh I see the PR has made from that account What do i need to do now?

@priyankarpal
Copy link
Owner

@Monilprajapati will check soon. Is it your other account? https://github.com/maxpratz

Yeahhh I created for an event purpose which i am going to conduct in the next week in my college. Is there any problem?

Ohhh I see the PR has made from that account What do i need to do now?

whenever you contribute please try to use a single account it will help to verify the person

@Monilprajapati
Copy link
Contributor Author

@Monilprajapati will check soon. Is it your other account? https://github.com/maxpratz

Yeahhh I created for an event purpose which i am going to conduct in the next week in my college. Is there any problem?

Ohhh I see the PR has made from that account What do i need to do now?

whenever you contribute please try to use a single account it will help to verify the person

Okkk Will take care from next time Thank you is there any futher steps to follow?

@priyankarpal
Copy link
Owner

@Monilprajapati will check soon. Is it your other account? https://github.com/maxpratz

Yeahhh I created for an event purpose which i am going to conduct in the next week in my college. Is there any problem?

Ohhh I see the PR has made from that account What do i need to do now?

whenever you contribute please try to use a single account it will help to verify the person

Okkk Will take care from next time Thank you is there any futher steps to follow?

you can check the website for best practices https://opensource.creativecommons.org/

Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit cb9f9ab into priyankarpal:main Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants